[libc++] Fix broken unique and unique_copy benchmarks #158287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These benchmarks have an assumption that the container size is divisible by 4 because of how we populate their content, which wasn't satisfied.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesThese benchmarks have an assumption that the container size is divisible by 4 because of how we populate their content, which wasn't satisfied. Full diff: https://github.com/llvm/llvm-project/pull/158287.diff 2 Files Affected:
diff --git a/libcxx/test/benchmarks/algorithms/modifying/unique.bench.cpp b/libcxx/test/benchmarks/algorithms/modifying/unique.bench.cpp
index c0aee942eef64..e3ac50187ef4b 100644
--- a/libcxx/test/benchmarks/algorithms/modifying/unique.bench.cpp
+++ b/libcxx/test/benchmarks/algorithms/modifying/unique.bench.cpp
@@ -76,7 +76,7 @@ int main(int argc, char** argv) {
}
})
->Arg(32)
- ->Arg(50) // non power-of-two
+ ->Arg(52) // non power-of-two
->Arg(1024)
->Arg(8192);
};
@@ -143,7 +143,7 @@ int main(int argc, char** argv) {
}
})
->Arg(32)
- ->Arg(50) // non power-of-two
+ ->Arg(52) // non power-of-two
->Arg(1024)
->Arg(8192);
};
diff --git a/libcxx/test/benchmarks/algorithms/modifying/unique_copy.bench.cpp b/libcxx/test/benchmarks/algorithms/modifying/unique_copy.bench.cpp
index 45b52dd23b695..1885b53e51413 100644
--- a/libcxx/test/benchmarks/algorithms/modifying/unique_copy.bench.cpp
+++ b/libcxx/test/benchmarks/algorithms/modifying/unique_copy.bench.cpp
@@ -61,6 +61,7 @@ int main(int argc, char** argv) {
}
})
->Arg(32)
+ ->Arg(52) // non power-of-two
->Arg(1024)
->Arg(8192);
};
@@ -115,7 +116,7 @@ int main(int argc, char** argv) {
}
})
->Arg(32)
- ->Arg(50) // non power-of-two
+ ->Arg(52) // non power-of-two
->Arg(1024)
->Arg(8192);
};
|
ldionne
changed the title
|
/libcxx-bot benchmark libcxx/test/benchmarks/algorithms/modifying/unique.bench.cpp libcxx/test/benchmarks/algorithms/modifying/unique_copy.bench.cpp Benchmark results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These benchmarks have an assumption that the container size is divisible by 4 because of how we populate their content, which wasn't satisfied.